diff options
| author | Leann Ogasawara <ogasawara@osdl.org> | 2004-03-10 18:57:27 -0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <greg@kroah.com> | 2004-03-10 18:57:27 -0800 |
| commit | bd37147c84ffa45219f05685b00df2ed4f3f088b (patch) | |
| tree | e3e1572f7cee5af01969b51942e0c7b92c8ec7f8 /drivers/base/class.c | |
| parent | 4740d0851cf6e6713b19b92c307e4e7d66a0ab30 (diff) | |
[PATCH] Fix class_register() always returns 0
I noticed that the class_register() function in drivers/base/class.c
always returns 0 and thus will never fail. Patch below inserts simple
error checking to return any errors if they occur. Feedback welcome.
Thanks,
Diffstat (limited to 'drivers/base/class.c')
| -rw-r--r-- | drivers/base/class.c | 12 |
1 files changed, 10 insertions, 2 deletions
diff --git a/drivers/base/class.c b/drivers/base/class.c index 1befa1107437..f6a96e931788 100644 --- a/drivers/base/class.c +++ b/drivers/base/class.c @@ -102,13 +102,21 @@ void class_put(struct class * cls) int class_register(struct class * cls) { + int error; + pr_debug("device class '%s': registering\n",cls->name); INIT_LIST_HEAD(&cls->children); INIT_LIST_HEAD(&cls->interfaces); - kobject_set_name(&cls->subsys.kset.kobj,cls->name); + error = kobject_set_name(&cls->subsys.kset.kobj,cls->name); + if (error) + return error; + subsys_set_kset(cls,class_subsys); - subsystem_register(&cls->subsys); + + error = subsystem_register(&cls->subsys); + if (error) + return error; return 0; } |
