summaryrefslogtreecommitdiff
path: root/drivers/base
diff options
context:
space:
mode:
authorPatrick Mochel <mochel@osdl.org>2002-10-16 22:07:11 -0700
committerPatrick Mochel <mochel@osdl.org>2002-10-16 22:07:11 -0700
commitbe0b9c71e35ebee75fc694daa9f2a268b504ca50 (patch)
tree8d5b8f6576758f593b91beb236cd8c1f0034c6e5 /drivers/base
parent6b1febf70889295545f50cc0d05312eaf6daa0a2 (diff)
driver model: change struct device::present to enumerated value with multiple states.
Adapted from Greg KH: - add multiple possible enumerated states a device can be in: UNINITIALIZED, INITIALIZED, REGISTERED, and GONE. - Check whether device is INITIALIZED or REGISTERED in device_present(). - Change struct device::current_state to ::power_state to better reflect what it is.
Diffstat (limited to 'drivers/base')
-rw-r--r--drivers/base/core.c9
-rw-r--r--drivers/base/interface.c2
2 files changed, 6 insertions, 5 deletions
diff --git a/drivers/base/core.c b/drivers/base/core.c
index c7f2fcfd480c..bd82a792d877 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -33,7 +33,7 @@ int device_add(struct device *dev)
return -EINVAL;
down(&device_sem);
- dev->present = 1;
+ dev->state = DEVICE_REGISTERED;
if (dev->parent) {
list_add_tail(&dev->g_list,&dev->parent->g_list);
list_add_tail(&dev->node,&dev->parent->children);
@@ -77,6 +77,7 @@ void device_initialize(struct device *dev)
INIT_LIST_HEAD(&dev->intf_list);
spin_lock_init(&dev->lock);
atomic_set(&dev->refcount,1);
+ dev->state = DEVICE_INITIALIZED;
if (dev->parent)
get_device(dev->parent);
}
@@ -112,7 +113,7 @@ struct device * get_device(struct device * dev)
{
struct device * ret = dev;
down(&device_sem);
- if (dev && dev->present && atomic_read(&dev->refcount) > 0)
+ if (device_present(dev) && atomic_read(&dev->refcount) > 0)
atomic_inc(&dev->refcount);
else
ret = NULL;
@@ -135,7 +136,7 @@ void put_device(struct device * dev)
list_del_init(&dev->g_list);
up(&device_sem);
- BUG_ON(dev->present);
+ BUG_ON((dev->state != DEVICE_GONE));
device_del(dev);
}
@@ -177,7 +178,7 @@ void device_del(struct device * dev)
void device_unregister(struct device * dev)
{
down(&device_sem);
- dev->present = 0;
+ dev->state = DEVICE_GONE;
up(&device_sem);
pr_debug("DEV: Unregistering device. ID = '%s', name = '%s'\n",
diff --git a/drivers/base/interface.c b/drivers/base/interface.c
index a585b729c5c4..8a5c6e6bc226 100644
--- a/drivers/base/interface.c
+++ b/drivers/base/interface.c
@@ -19,7 +19,7 @@ static DEVICE_ATTR(name,S_IRUGO,device_read_name,NULL);
static ssize_t
device_read_power(struct device * dev, char * page, size_t count, loff_t off)
{
- return off ? 0 : sprintf(page,"%d\n",dev->current_state);
+ return off ? 0 : sprintf(page,"%d\n",dev->power_state);
}
static ssize_t