diff options
| author | Christian König <christian.koenig@amd.com> | 2022-09-28 20:31:38 +0200 | 
|---|---|---|
| committer | Christian König <christian.koenig@amd.com> | 2022-11-03 12:45:20 +0100 | 
| commit | f7d66fb2ea43a3016e78a700a2ca6c77a74579f9 (patch) | |
| tree | 86cde4157e5735e0f325dd239b515cdc7c908e36 /drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | |
| parent | 940ca22b7ea9db6857ba7c6adb961b84d8cc28ff (diff) | |
drm/amdgpu: cleanup scheduler job initialization v2
Init the DRM scheduler base class while allocating the job.
This makes the whole handling much more cleaner.
v2: fix coding style
Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Luben Tuikov <luben.tuikov@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20221014084641.128280-7-christian.koenig@amd.com
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c')
| -rw-r--r-- | drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 22 | 
1 files changed, 13 insertions, 9 deletions
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c index 0b52af415b28..3449145ab2bc 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c @@ -600,15 +600,16 @@ static int amdgpu_vcn_dec_send_msg(struct amdgpu_ring *ring,  				   struct amdgpu_ib *ib_msg,  				   struct dma_fence **fence)  { +	u64 addr = AMDGPU_GPU_PAGE_ALIGN(ib_msg->gpu_addr);  	struct amdgpu_device *adev = ring->adev;  	struct dma_fence *f = NULL;  	struct amdgpu_job *job;  	struct amdgpu_ib *ib; -	uint64_t addr = AMDGPU_GPU_PAGE_ALIGN(ib_msg->gpu_addr);  	int i, r; -	r = amdgpu_job_alloc_with_ib(adev, 64, -					AMDGPU_IB_POOL_DIRECT, &job); +	r = amdgpu_job_alloc_with_ib(ring->adev, NULL, NULL, +				     64, AMDGPU_IB_POOL_DIRECT, +				     &job);  	if (r)  		goto err; @@ -787,8 +788,9 @@ static int amdgpu_vcn_dec_sw_send_msg(struct amdgpu_ring *ring,  	if (sq)  		ib_size_dw += 8; -	r = amdgpu_job_alloc_with_ib(adev, ib_size_dw * 4, -				AMDGPU_IB_POOL_DIRECT, &job); +	r = amdgpu_job_alloc_with_ib(ring->adev, NULL, NULL, +				     ib_size_dw * 4, AMDGPU_IB_POOL_DIRECT, +				     &job);  	if (r)  		goto err; @@ -916,8 +918,9 @@ static int amdgpu_vcn_enc_get_create_msg(struct amdgpu_ring *ring, uint32_t hand  	if (sq)  		ib_size_dw += 8; -	r = amdgpu_job_alloc_with_ib(ring->adev, ib_size_dw * 4, -					AMDGPU_IB_POOL_DIRECT, &job); +	r = amdgpu_job_alloc_with_ib(ring->adev, NULL, NULL, +				     ib_size_dw * 4, AMDGPU_IB_POOL_DIRECT, +				     &job);  	if (r)  		return r; @@ -982,8 +985,9 @@ static int amdgpu_vcn_enc_get_destroy_msg(struct amdgpu_ring *ring, uint32_t han  	if (sq)  		ib_size_dw += 8; -	r = amdgpu_job_alloc_with_ib(ring->adev, ib_size_dw * 4, -					AMDGPU_IB_POOL_DIRECT, &job); +	r = amdgpu_job_alloc_with_ib(ring->adev, NULL, NULL, +				     ib_size_dw * 4, AMDGPU_IB_POOL_DIRECT, +				     &job);  	if (r)  		return r;  | 
