diff options
| author | Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> | 2025-01-14 21:07:26 +0100 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2025-02-13 21:54:55 +0530 |
| commit | 836c8a2edb96d78de6f00b60d6d8e24f2ea87e57 (patch) | |
| tree | 6b164df44eafcec1194687612948306d93a11730 /drivers/soundwire/debugfs.c | |
| parent | 3df75289ddc28b46121d51d2812943b78676497b (diff) | |
soundwire: Use str_enable_disable-like helpers
Replace ternary (condition ? "enable" : "disable") syntax with helpers
from string_choices.h because:
1. Simple function call with one argument is easier to read. Ternary
operator has three arguments and with wrapping might lead to quite
long code.
2. Is slightly shorter thus also easier to read.
3. It brings uniformity in the text - same string.
4. Allows deduping by the linker, which results in a smaller binary
file.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20250114200726.969501-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/soundwire/debugfs.c')
| -rw-r--r-- | drivers/soundwire/debugfs.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/soundwire/debugfs.c b/drivers/soundwire/debugfs.c index c30f571934ee..5bf0d9552433 100644 --- a/drivers/soundwire/debugfs.c +++ b/drivers/soundwire/debugfs.c @@ -10,6 +10,7 @@ #include <linux/slab.h> #include <linux/soundwire/sdw.h> #include <linux/soundwire/sdw_registers.h> +#include <linux/string_choices.h> #include "bus.h" static struct dentry *sdw_debugfs_root; @@ -153,7 +154,7 @@ static int set_command(void *data, u64 value) /* Userspace changed the hardware state behind the kernel's back */ add_taint(TAINT_USER, LOCKDEP_STILL_OK); - dev_dbg(&slave->dev, "command: %s\n", value ? "read" : "write"); + dev_dbg(&slave->dev, "command: %s\n", str_read_write(value)); cmd = value; return 0; |