diff options
| author | Thomas Gleixner <tglx@linutronix.de> | 2018-06-22 21:20:35 +0200 | 
|---|---|---|
| committer | Thomas Gleixner <tglx@linutronix.de> | 2018-06-22 21:20:35 +0200 | 
| commit | 7731b8bc94e599c9a79e428f3359ff2c34b7576a (patch) | |
| tree | 879f18ccbe274122f2d4f095b43cbc7f953e0ada /drivers/usb/dwc3/debugfs.c | |
| parent | 48e315618dc4dc8904182cd221e3d395d5d97005 (diff) | |
| parent | 9ffc59d57228d74809700be6f7ecb1db10292f05 (diff) | |
Merge branch 'linus' into x86/urgent
Required to queue a dependent fix.
Diffstat (limited to 'drivers/usb/dwc3/debugfs.c')
| -rw-r--r-- | drivers/usb/dwc3/debugfs.c | 43 | 
1 files changed, 11 insertions, 32 deletions
diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c index 2f07be1e1f31..df8e73ec3342 100644 --- a/drivers/usb/dwc3/debugfs.c +++ b/drivers/usb/dwc3/debugfs.c @@ -716,9 +716,6 @@ static void dwc3_debugfs_create_endpoint_dir(struct dwc3_ep *dep,  	struct dentry		*dir;  	dir = debugfs_create_dir(dep->name, parent); -	if (IS_ERR_OR_NULL(dir)) -		return; -  	dwc3_debugfs_create_endpoint_files(dep, dir);  } @@ -740,49 +737,31 @@ static void dwc3_debugfs_create_endpoint_dirs(struct dwc3 *dwc,  void dwc3_debugfs_init(struct dwc3 *dwc)  {  	struct dentry		*root; -	struct dentry           *file; - -	root = debugfs_create_dir(dev_name(dwc->dev), NULL); -	if (IS_ERR_OR_NULL(root)) { -		if (!root) -			dev_err(dwc->dev, "Can't create debugfs root\n"); -		return; -	} -	dwc->root = root;  	dwc->regset = kzalloc(sizeof(*dwc->regset), GFP_KERNEL); -	if (!dwc->regset) { -		debugfs_remove_recursive(root); +	if (!dwc->regset)  		return; -	}  	dwc->regset->regs = dwc3_regs;  	dwc->regset->nregs = ARRAY_SIZE(dwc3_regs);  	dwc->regset->base = dwc->regs - DWC3_GLOBALS_REGS_START; -	file = debugfs_create_regset32("regdump", S_IRUGO, root, dwc->regset); -	if (!file) -		dev_dbg(dwc->dev, "Can't create debugfs regdump\n"); +	root = debugfs_create_dir(dev_name(dwc->dev), NULL); +	dwc->root = root; + +	debugfs_create_regset32("regdump", S_IRUGO, root, dwc->regset);  	if (IS_ENABLED(CONFIG_USB_DWC3_DUAL_ROLE)) { -		file = debugfs_create_file("mode", S_IRUGO | S_IWUSR, root, -				dwc, &dwc3_mode_fops); -		if (!file) -			dev_dbg(dwc->dev, "Can't create debugfs mode\n"); +		debugfs_create_file("mode", S_IRUGO | S_IWUSR, root, dwc, +				    &dwc3_mode_fops);  	}  	if (IS_ENABLED(CONFIG_USB_DWC3_DUAL_ROLE) ||  			IS_ENABLED(CONFIG_USB_DWC3_GADGET)) { -		file = debugfs_create_file("testmode", S_IRUGO | S_IWUSR, root, -				dwc, &dwc3_testmode_fops); -		if (!file) -			dev_dbg(dwc->dev, "Can't create debugfs testmode\n"); - -		file = debugfs_create_file("link_state", S_IRUGO | S_IWUSR, -				root, dwc, &dwc3_link_state_fops); -		if (!file) -			dev_dbg(dwc->dev, "Can't create debugfs link_state\n"); - +		debugfs_create_file("testmode", S_IRUGO | S_IWUSR, root, dwc, +				    &dwc3_testmode_fops); +		debugfs_create_file("link_state", S_IRUGO | S_IWUSR, root, dwc, +				    &dwc3_link_state_fops);  		dwc3_debugfs_create_endpoint_dirs(dwc, root);  	}  }  | 
