diff options
| author | Zilin Guan <zilin@seu.edu.cn> | 2025-12-25 14:31:50 +0000 |
|---|---|---|
| committer | Alex Williamson <alex@shazbot.org> | 2025-12-28 12:33:40 -0700 |
| commit | 665077d78dc7941ce6a330c02023a2b469cc8cc7 (patch) | |
| tree | 47a5879f1547fdfaf7fb652b582ba31097e40b66 /drivers | |
| parent | 193120dddd1a1f3dcae164289498588fa0544d78 (diff) | |
vfio/pds: Fix memory leak in pds_vfio_dirty_enable()
pds_vfio_dirty_enable() allocates memory for region_info. If
interval_tree_iter_first() returns NULL, the function returns -EINVAL
immediately without freeing the allocated memory, causing a memory leak.
Fix this by jumping to the out_free_region_info label to ensure
region_info is freed.
Fixes: 2e7c6feb4ef52 ("vfio/pds: Add multi-region support")
Signed-off-by: Zilin Guan <zilin@seu.edu.cn>
Link: https://lore.kernel.org/r/20251225143150.1117366-1-zilin@seu.edu.cn
Signed-off-by: Alex Williamson <alex@shazbot.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/vfio/pci/pds/dirty.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/vfio/pci/pds/dirty.c b/drivers/vfio/pci/pds/dirty.c index 481992142f79..4915a7c1c491 100644 --- a/drivers/vfio/pci/pds/dirty.c +++ b/drivers/vfio/pci/pds/dirty.c @@ -292,8 +292,11 @@ static int pds_vfio_dirty_enable(struct pds_vfio_pci_device *pds_vfio, len = num_ranges * sizeof(*region_info); node = interval_tree_iter_first(ranges, 0, ULONG_MAX); - if (!node) - return -EINVAL; + if (!node) { + err = -EINVAL; + goto out_free_region_info; + } + for (int i = 0; i < num_ranges; i++) { struct pds_lm_dirty_region_info *ri = ®ion_info[i]; u64 region_size = node->last - node->start + 1; |