diff options
| author | Arjan van de Ven <arjan@infradead.org> | 2004-11-07 04:02:44 -0800 |
|---|---|---|
| committer | Linus Torvalds <torvalds@ppc970.osdl.org> | 2004-11-07 04:02:44 -0800 |
| commit | 857c46acab86c3966bdcd007d2db2360f74dbc91 (patch) | |
| tree | 2934b6c6d325b8c749af4149db96db79e935aa33 /fs/jbd/commit.c | |
| parent | 03d234808af3114835151019848b119b46d86bff (diff) | |
[PATCH] remove journal callback code from jbd
With the demise of intermezzo, the journal callback stuff in jbd is
entirely unused (neither ext3 nor ocfs2 use it), and thus will only bitrot
and bloat the kernel with code and datastructure growth. If intermezzo
ever gets resurrected this will be the least of the problems they have to
face (both with generic kernel as jbd).
Signed-off-by: Arjan van de Ven <arjan@infradead.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'fs/jbd/commit.c')
| -rw-r--r-- | fs/jbd/commit.c | 24 |
1 files changed, 0 insertions, 24 deletions
diff --git a/fs/jbd/commit.c b/fs/jbd/commit.c index b4d6654ef7f2..875e06ba9aba 100644 --- a/fs/jbd/commit.c +++ b/fs/jbd/commit.c @@ -686,30 +686,6 @@ skip_commit: /* The journal should be unlocked by now. */ if (err) __journal_abort_hard(journal); - /* - * Call any callbacks that had been registered for handles in this - * transaction. It is up to the callback to free any allocated - * memory. - * - * The spinlocking (t_jcb_lock) here is surely unnecessary... - */ - spin_lock(&commit_transaction->t_jcb_lock); - if (!list_empty(&commit_transaction->t_jcb)) { - struct list_head *p, *n; - int error = is_journal_aborted(journal); - - list_for_each_safe(p, n, &commit_transaction->t_jcb) { - struct journal_callback *jcb; - - jcb = list_entry(p, struct journal_callback, jcb_list); - list_del(p); - spin_unlock(&commit_transaction->t_jcb_lock); - jcb->jcb_func(jcb, error); - spin_lock(&commit_transaction->t_jcb_lock); - } - } - spin_unlock(&commit_transaction->t_jcb_lock); - jbd_debug(3, "JBD: commit phase 7\n"); J_ASSERT(commit_transaction->t_sync_datalist == NULL); |
