summaryrefslogtreecommitdiff
path: root/include/clocksource
diff options
context:
space:
mode:
authorNathan Chancellor <natechancellor@gmail.com>2020-03-10 15:06:54 -0700
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2020-04-01 11:01:55 +0200
commit753ea21f2ac318d8169a8f7800f7f8b93ccce614 (patch)
treee70a526a317f8c3760adbfe3958349919e000d75 /include/clocksource
parent27030150699b534d80514bb1a580504dda1e6ef7 (diff)
dpaa_eth: Remove unnecessary boolean expression in dpaa_get_headroom
[ Upstream commit 7395f62d95aafacdb9bd4996ec2f95b4a655d7e6 ] Clang warns: drivers/net/ethernet/freescale/dpaa/dpaa_eth.c:2860:9: warning: converting the result of '?:' with integer constants to a boolean always evaluates to 'true' [-Wtautological-constant-compare] return DPAA_FD_DATA_ALIGNMENT ? ALIGN(headroom, ^ drivers/net/ethernet/freescale/dpaa/dpaa_eth.c:131:34: note: expanded from macro 'DPAA_FD_DATA_ALIGNMENT' \#define DPAA_FD_DATA_ALIGNMENT (fman_has_errata_a050385() ? 64 : 16) ^ 1 warning generated. This was exposed by commit 3c68b8fffb48 ("dpaa_eth: FMan erratum A050385 workaround") even though it appears to have been an issue since the introductory commit 9ad1a3749333 ("dpaa_eth: add support for DPAA Ethernet") since DPAA_FD_DATA_ALIGNMENT has never been able to be zero. Just replace the whole boolean expression with the true branch, as it is always been true. Link: https://github.com/ClangBuiltLinux/linux/issues/928 Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Reviewed-by: Madalin Bucur <madalin.bucur@oss.nxp.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'include/clocksource')
0 files changed, 0 insertions, 0 deletions