diff options
| author | Martin Dalecki <dalecki@evision-ventures.com> | 2002-05-21 21:22:11 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@home.transmeta.com> | 2002-05-21 21:22:11 -0700 |
| commit | 6b4fef7ad8297f840fc6c1a8e6ff3ca7a525fb2b (patch) | |
| tree | 3c6ccaf86e0ea9c26bb0f6686b3017f4190114a8 /include/linux/blkdev.h | |
| parent | 694793903207ecf6a4a1b508b636f02cfb3a3016 (diff) | |
[PATCH] 2.5.17 IDE 66
- Move ll_10byte_cmd_build to the only place where it's used: ide-cd. The SCSI
layer does have it's own implementation which additionally it's messing
around with the hard_nr_sectors struct request value. One should *not*
provide "infrastructure" until its really used as such.
If anywhere this should reside in a file called ATAPI.
- Unfold the INIT_REQUEST macro from blk.h. This showed up plenty of duplicate
checks for QUEUE_EMPTY. Clean them as well. Remove the over cautious
major(CURRENT->rq_dev != MAJOR_NR) checks. During the last several years I
never saw any report about it. Looking at the !CURRENT->bio it is clear that
dereferencing NULL will provide the same kind of panic as the check. Some
comments around the code in question show nicely that indeed INIT_REQUEST
was a good example of code obfuscation.
- A short look at RQ_INACTIVE shows that it is only used inside the scsi.c file
and during the removal of devices. This shows that the many checks for
RQ_INACTIVE are not necessary. Looking closer even shows that some of them
did happen before checks for an empty queue. Plenty of drivers didn't care
about it and the CD-ROM ones should be handled properly, because the
most common drivers would fail as well. Comments indicate that this
was an leftover from 1.3 days...
Diffstat (limited to 'include/linux/blkdev.h')
| -rw-r--r-- | include/linux/blkdev.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index ac373e6a2454..32729e1e3c5b 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -303,7 +303,6 @@ extern void blk_recount_segments(request_queue_t *, struct bio *); extern inline int blk_phys_contig_segment(request_queue_t *q, struct bio *, struct bio *); extern inline int blk_hw_contig_segment(request_queue_t *q, struct bio *, struct bio *); extern int block_ioctl(struct block_device *, unsigned int, unsigned long); -extern int ll_10byte_cmd_build(request_queue_t *, struct request *); /* * get ready for proper ref counting |