diff options
| author | Andrew Morton <akpm@digeo.com> | 2003-02-02 06:07:16 -0800 |
|---|---|---|
| committer | Linus Torvalds <torvalds@home.transmeta.com> | 2003-02-02 06:07:16 -0800 |
| commit | 2ef0192ceb2f9e5e28225b92886ee71676988d28 (patch) | |
| tree | 70026843d928502f6cdae2854d13fd638591f3f2 /include/linux/buffer_head.h | |
| parent | 359ae811d3acf016ae4fd6dcd0fd7b59892c3b33 (diff) | |
[PATCH] ext2_new_block cleanups and fixes
The general error logic handling in there is:
*errp = -EFOO;
<lots of code>
if (some_error)
goto out;
this is fragile and unmaintainable, because the setting of the error code is
"far away" from the site where the error was detected.
And the code was actually wrong - we're returning ENOSPC in places where fs
metadata inconsistency was detected. We traditionally return -EIO in this
case.
So change it all to do, effectively:
if (some_error) {
*errp = -EFOO;
goto out;
}
Diffstat (limited to 'include/linux/buffer_head.h')
0 files changed, 0 insertions, 0 deletions
