diff options
| author | Herton R. Krzesinski <herton@redhat.com> | 2016-01-11 12:07:43 -0200 |
|---|---|---|
| committer | Luis Henriques <luis.henriques@canonical.com> | 2016-02-25 10:34:47 +0000 |
| commit | 0efc1c2d06dab4cbd787af2ab32582e7e6d65ea4 (patch) | |
| tree | b9d0629965910100faa45725020ff2b5696f5e4c /include/linux/devpts_fs.h | |
| parent | 546e99d81f7b365d25ae61318d9113a26bef806f (diff) | |
pty: fix possible use after free of tty->driver_data
commit 2831c89f42dcde440cfdccb9fee9f42d54bbc1ef upstream.
This change fixes a bug for a corner case where we have the the last
release from a pty master/slave coming from a previously opened /dev/tty
file. When this happens, the tty->driver_data can be stale, due to all
ptmx or pts/N files having already been closed before (and thus the inode
related to these files, which tty->driver_data points to, being already
freed/destroyed).
The fix here is to keep a reference on the opened master ptmx inode.
We maintain the inode referenced until the final pty_unix98_shutdown,
and only pass this inode to devpts_kill_index.
Signed-off-by: Herton R. Krzesinski <herton@redhat.com>
Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
Diffstat (limited to 'include/linux/devpts_fs.h')
0 files changed, 0 insertions, 0 deletions