summaryrefslogtreecommitdiff
path: root/include/linux/hid.h
diff options
context:
space:
mode:
authorJohan Korsnes <jkorsnes@cisco.com>2020-01-17 13:08:35 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2020-03-05 16:42:18 +0100
commit75c3955b160d32a7faac6db094960c35723eebd4 (patch)
tree6d65033de825c2fa77461dec3fb2ba1b85112873 /include/linux/hid.h
parent30f22a3842f50b8af9a5c540f541aeb05a13d7e2 (diff)
HID: core: fix off-by-one memset in hid_report_raw_event()
commit 5ebdffd25098898aff1249ae2f7dbfddd76d8f8f upstream. In case a report is greater than HID_MAX_BUFFER_SIZE, it is truncated, but the report-number byte is not correctly handled. This results in a off-by-one in the following memset, causing a kernel Oops and ensuing system crash. Note: With commit 8ec321e96e05 ("HID: Fix slab-out-of-bounds read in hid_field_extract") I no longer hit the kernel Oops as we instead fail "controlled" at probe if there is a report too long in the HID report-descriptor. hid_report_raw_event() is an exported symbol, so presumabely we cannot always rely on this being the case. Fixes: 966922f26c7f ("HID: fix a crash in hid_report_raw_event() function.") Signed-off-by: Johan Korsnes <jkorsnes@cisco.com> Cc: Armando Visconti <armando.visconti@st.com> Cc: Jiri Kosina <jkosina@suse.cz> Cc: Alan Stern <stern@rowland.harvard.edu> Signed-off-by: Jiri Kosina <jkosina@suse.cz> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'include/linux/hid.h')
0 files changed, 0 insertions, 0 deletions