diff options
| author | Thomas Gleixner <tglx@linutronix.de> | 2021-07-29 23:51:44 +0200 |
|---|---|---|
| committer | Sasha Levin <sashal@kernel.org> | 2021-08-26 08:36:41 -0400 |
| commit | 22f4a36d086d74f7abe9c4eaf65204048cd84f9c (patch) | |
| tree | d8f5653eabcb061b24677d8dea026fd54e6abe60 /include/linux/hypervisor.h | |
| parent | 6aea847496c8c9a37a5df795c4fe42a0e5fcccc5 (diff) | |
PCI/MSI: Do not set invalid bits in MSI mask
commit 361fd37397f77578735907341579397d5bed0a2d upstream.
msi_mask_irq() takes a mask and a flags argument. The mask argument is used
to mask out bits from the cached mask and the flags argument to set bits.
Some places invoke it with a flags argument which sets bits which are not
used by the device, i.e. when the device supports up to 8 vectors a full
unmask in some places sets the mask to 0xFFFFFF00. While devices probably
do not care, it's still bad practice.
Fixes: 7ba1930db02f ("PCI MSI: Unmask MSI if setup failed")
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Marc Zyngier <maz@kernel.org>
Reviewed-by: Marc Zyngier <maz@kernel.org>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20210729222542.568173099@linutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'include/linux/hypervisor.h')
0 files changed, 0 insertions, 0 deletions
