diff options
| author | Mike Snitzer <snitzer@redhat.com> | 2020-09-14 13:04:19 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-10-01 13:18:25 +0200 |
| commit | 3d9f39d274eaee792b9d3d637fb0f935a79d482d (patch) | |
| tree | cc052ea85ee59eb6fd19d62306ea7ddc2ced1542 /include/linux/libata.h | |
| parent | c9bfb7b4d944c9b2294426efc0d30a7c9bb4c2b1 (diff) | |
dm: fix bio splitting and its bio completion order for regular IO
commit ee1dfad5325ff1cfb2239e564cd411b3bfe8667a upstream.
dm_queue_split() is removed because __split_and_process_bio() _must_
handle splitting bios to ensure proper bio submission and completion
ordering as a bio is split.
Otherwise, multiple recursive calls to ->submit_bio will cause multiple
split bios to be allocated from the same ->bio_split mempool at the same
time. This would result in deadlock in low memory conditions because no
progress could be made (only one bio is available in ->bio_split
mempool).
This fix has been verified to still fix the loss of performance, due
to excess splitting, that commit 120c9257f5f1 provided.
Fixes: 120c9257f5f1 ("Revert "dm: always call blk_queue_split() in dm_process_bio()"")
Cc: stable@vger.kernel.org # 5.0+, requires custom backport due to 5.9 changes
Reported-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'include/linux/libata.h')
0 files changed, 0 insertions, 0 deletions
