diff options
| author | Dave Hansen <haveblue@us.ibm.com> | 2004-08-09 21:47:59 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@ppc970.osdl.org> | 2004-08-09 21:47:59 -0700 |
| commit | 384278b0d36291bc207d628251eb3b64d387c596 (patch) | |
| tree | 5cf7d1e04f0ebf05e463f4341605822c4a9c4a90 /include/linux/mtd/physmap.h | |
| parent | 69bbb2ba68a02a9918feac48c43af24eb2aa9625 (diff) | |
[PATCH] 4kstacks: fix compile with gcc 2.95
Investigation of why the build is failing due to bogus detection of
undefined symbols: We're getting this warning:
arch/i386/kernel/irq.c
{standard input}: Assembler messages:
{standard input}:3565: Warning: setting incorrect section type for
.bss.page_aligned
Which comes from this code in the 4k stacks code:
static char softirq_stack[NR_CPUS * THREAD_SIZE] __attribute__((__aligned__(THREAD_SIZE), __section__(".bss.page_aligned")));
static char hardirq_stack[NR_CPUS * THREAD_SIZE] __attribute__((__aligned__(THREAD_SIZE), __section__(".bss.page_aligned")));
Removing the __section__() fixes it, as does moving to gcc 3.2 or 3.3,
but gcc 2.95 and 3.0 still exhibit the problem. It seems the 4k stack
developers like newer compilers than I do :)
The gcc 2.95 section declaration looks like this:
.section .bss.page_aligned,"aw",@progbits
while the 3.1 section looks like this:
.section .bss.page_aligned,"aw",@nobits
It's definitely a bug that's been fixed:
http://sources.redhat.com/ml/binutils/2002-10/msg00507.html
I've been told that I can fix it with a carefully crafted assembly file and
maybe a change to the linker script, but all that it buys us is a little
space in the uncompressed kernel image. Plus, the warning will still be
there at compile-time.
I say, put them back in plain old BSS.
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Adrian Bunk <bunk@fs.tum.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'include/linux/mtd/physmap.h')
0 files changed, 0 insertions, 0 deletions
