diff options
| author | Stephen C. Tweedie <sct@redhat.com> | 2005-01-04 05:27:49 -0800 |
|---|---|---|
| committer | Linus Torvalds <torvalds@ppc970.osdl.org> | 2005-01-04 05:27:49 -0800 |
| commit | a319278834bd1e9e7b14910ffe3ddf7485817941 (patch) | |
| tree | 2c2ef65a6da3096dcf52760f312ddfcdf62fab2b /include/linux/ppdev.h | |
| parent | c579b4e22af013e1c6745023a6bb37756d38fc52 (diff) | |
[PATCH] ext3: handle attempted double-delete of metadata.
This patch improves ext3's ability to deal with corruption on-disk. If we
try to delete a metadata block twice, we confuse ext3's internal revoke
error-checking, resulting in a BUG(). But this can occur in practice due
to a corrupt indirect block, so we should attempt to fail gracefully.
Downgrade the assert failure to a JH_EXPECT_BH failure, and return EIO when
it occurs.
This is easily reproduced with a sample ext3 fs image containing an inode
which references the same indirect block more than once. Deleting that
inode will BUG() an unfixed kernel with:
Assertion failure in journal_revoke() at fs/jbd/revoke.c:379:
"!buffer_revoked(bh)"
With the fix, ext3 recovers gracefully.
Signed-off-by: Stephen Tweedie <sct@redhat.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'include/linux/ppdev.h')
0 files changed, 0 insertions, 0 deletions
