diff options
| author | Andrew Morton <akpm@osdl.org> | 2003-08-06 08:57:31 -0700 |
|---|---|---|
| committer | Dave Jones <davej@redhat.com> | 2003-08-06 08:57:31 -0700 |
| commit | 7ec6fb01ef95f0832771b581914fd047e4696bde (patch) | |
| tree | bf98f57b196bc48c40fd40a69f6185d61a098016 /include/linux/sched.h | |
| parent | a9c7b26ba42feb750fb47fd9335c3f43bdb8b51c (diff) | |
[PATCH] remove PF_READAHEAD
The problem with PF_READAHEAD is that if someone does a non-GFP_ATOMIC memory
allocation we can enter page reclaim and then call writepage, while
PF_READAHEAD is set. The block layer then drops writes or the wrong reads on
the floor. It can cause data loss.
A fix is complex (well, intrusive). Given that the readahead code is now
skipping the entire readahead attempt if the queue is congested, the setting
of PF_READAHEAD probably is not doing anything useful anyway, so simply
remove it.
Diffstat (limited to 'include/linux/sched.h')
| -rw-r--r-- | include/linux/sched.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/include/linux/sched.h b/include/linux/sched.h index a7e52205b47a..70eb61ecf4a3 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -487,7 +487,6 @@ do { if (atomic_dec_and_test(&(tsk)->usage)) __put_task_struct(tsk); } while(0) #define PF_SWAPOFF 0x00080000 /* I am in swapoff */ #define PF_LESS_THROTTLE 0x00100000 /* Throttle me less: I clean memory */ #define PF_SYNCWRITE 0x00200000 /* I am doing a sync write */ -#define PF_READAHEAD 0x00400000 /* I am doing read-ahead */ #ifdef CONFIG_SMP extern int set_cpus_allowed(task_t *p, unsigned long new_mask); |