diff options
| author | Jason A. Donenfeld <Jason@zx2c4.com> | 2022-05-07 14:03:46 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-06-25 11:49:11 +0200 |
| commit | 68d98553debac41a906c69e286b9d2024a8fbf04 (patch) | |
| tree | 0aaadcd05b89e877b59a97c8545166cb687bb3bb /include/linux/stringhash.h | |
| parent | eb1b4a9287ef8f3033702841fc056fec10bd824c (diff) | |
siphash: use one source of truth for siphash permutations
commit e73aaae2fa9024832e1f42e30c787c7baf61d014 upstream.
The SipHash family of permutations is currently used in three places:
- siphash.c itself, used in the ordinary way it was intended.
- random32.c, in a construction from an anonymous contributor.
- random.c, as part of its fast_mix function.
Each one of these places reinvents the wheel with the same C code, same
rotation constants, and same symmetry-breaking constants.
This commit tidies things up a bit by placing macros for the
permutations and constants into siphash.h, where each of the three .c
users can access them. It also leaves a note dissuading more users of
them from emerging.
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'include/linux/stringhash.h')
0 files changed, 0 insertions, 0 deletions
