diff options
| author | David Brownell <david-b@pacbell.net> | 2002-10-06 19:54:53 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@home.transmeta.com> | 2002-10-06 19:54:53 -0700 |
| commit | 6ebb1e2d3e244a21a03579c0b490f1608482f5bb (patch) | |
| tree | 63e095d6b299cfcd06f5f18ac0e49f44f21035db /include/linux | |
| parent | 38b4e74829cc1b7a0870848f9c0900a843f6b9fc (diff) | |
[PATCH] pci/pool.c less spinlock abuse
That previous patch got rid of a boot time might_sleep() warning,
but I noticed two later on:
- kmalloc() needed SLAB_ATOMIC
- destroying the 'pools' driverfs attribute could sleep too
The clean/simple patch for the second one tweaked an API:
- pci_pool_create() can't be called in_interrupt() any more.
nobody used it there, and such support isn't needed; plus
that rule matches its sibling call, pci_pool_destroy().
- that made its SLAB_* flags parameter more useless, so it's
removed and the DMA-mapping.txt is updated. (this param
was more trouble than it was worth -- good that it's gone.)
Nobody (even DaveM) objected to those API changes, so I think
this should be merged.
Diffstat (limited to 'include/linux')
| -rw-r--r-- | include/linux/pci.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/pci.h b/include/linux/pci.h index 9c12d53f9dc7..fc4d5c7f5d1f 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -637,7 +637,7 @@ struct pci_bus * pci_add_new_bus(struct pci_bus *parent, struct pci_dev *dev, in /* kmem_cache style wrapper around pci_alloc_consistent() */ struct pci_pool *pci_pool_create (const char *name, struct pci_dev *dev, - size_t size, size_t align, size_t allocation, int flags); + size_t size, size_t align, size_t allocation); void pci_pool_destroy (struct pci_pool *pool); void *pci_pool_alloc (struct pci_pool *pool, int flags, dma_addr_t *handle); |
