diff options
| author | Vincent BENAYOUN <vincent.benayoun@trust-in-soft.com> | 2014-11-13 13:47:26 +0100 |
|---|---|---|
| committer | Luis Henriques <luis.henriques@canonical.com> | 2014-12-01 10:02:09 +0000 |
| commit | 8bd8e3f2c73a75684a12482f289796a52a572ddc (patch) | |
| tree | 2421a9e7e4f323d61c066a280f490bb8b183a3d0 /include/linux | |
| parent | 6153a856d7b4a208a678da5e2be293e8d44f1196 (diff) | |
inetdevice: fixed signed integer overflow
commit 84bc88688e3f6ef843aa8803dbcd90168bb89faf upstream.
There could be a signed overflow in the following code.
The expression, (32-logmask) is comprised between 0 and 31 included.
It may be equal to 31.
In such a case the left shift will produce a signed integer overflow.
According to the C99 Standard, this is an undefined behavior.
A simple fix is to replace the signed int 1 with the unsigned int 1U.
Signed-off-by: Vincent BENAYOUN <vincent.benayoun@trust-in-soft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
Diffstat (limited to 'include/linux')
| -rw-r--r-- | include/linux/inetdevice.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/inetdevice.h b/include/linux/inetdevice.h index 0068708161ff..0a21fbefdfbe 100644 --- a/include/linux/inetdevice.h +++ b/include/linux/inetdevice.h @@ -242,7 +242,7 @@ static inline void in_dev_put(struct in_device *idev) static __inline__ __be32 inet_make_mask(int logmask) { if (logmask) - return htonl(~((1<<(32-logmask))-1)); + return htonl(~((1U<<(32-logmask))-1)); return 0; } |