diff options
| author | Colin Ian King <colin.king@canonical.com> | 2018-11-25 17:09:18 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-01-27 14:50:25 +0100 |
| commit | b03bf452b4f687b7d6661472c48165532141fa58 (patch) | |
| tree | fd73e4bd881db313f9f9b5ed680ee43472e1c94c /include/linux | |
| parent | 9cef92d809914c64025fe8a47af9d6a2bce35e43 (diff) | |
drm/nouveau/bios/ramcfg: fix missing parentheses when calculating RON
[ Upstream commit 13649101a25c53c87f4ab98a076dfe61f3636ab1 ]
Currently, the expression for calculating RON is always going to result
in zero no matter the value of ram->mr[1] because the ! operator has
higher precedence than the shift >> operator. I believe the missing
parentheses around the expression before appying the ! operator will
result in the desired result.
[ Note, not tested ]
Detected by CoveritScan, CID#1324005 ("Operands don't affect result")
Fixes: c25bf7b6155c ("drm/nouveau/bios/ramcfg: Separate out RON pull value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'include/linux')
0 files changed, 0 insertions, 0 deletions