summaryrefslogtreecommitdiff
path: root/include/linux
diff options
context:
space:
mode:
authorYufen Yu <yuyufen@huawei.com>2019-01-29 16:34:04 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-03-23 20:09:45 +0100
commite01f2b0821ea9b68a485fdb94f3e86e6a40f913c (patch)
tree1676aa6311667ca7890e4b402dfdceddf4d05eb7 /include/linux
parent5ca2ef674d742b4283908f5df8ba523d38a58d91 (diff)
floppy: check_events callback should not return a negative number
[ Upstream commit 96d7cb932e826219ec41ac02e5af037ffae6098c ] floppy_check_events() is supposed to return bit flags to say which events occured. We should return zero to say that no event flags are set. Only BIT(0) and BIT(1) are used in the caller. And .check_events interface also expect to return an unsigned int value. However, after commit a0c80efe5956, it may return -EINTR (-4u). Here, both BIT(0) and BIT(1) are cleared. So this patch shouldn't affect runtime, but it obviously is still worth fixing. Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> Fixes: a0c80efe5956 ("floppy: fix lock_fdc() signal handling") Signed-off-by: Yufen Yu <yuyufen@huawei.com> Signed-off-by: Jens Axboe <axboe@kernel.dk> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'include/linux')
0 files changed, 0 insertions, 0 deletions