diff options
| author | Johan Hovold <johan@kernel.org> | 2021-04-08 15:16:01 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-05-22 10:59:31 +0200 |
| commit | e601f9a66b43dc715a2782017ff890fa028e9aa5 (patch) | |
| tree | ce559dd59c0cf002cb6288d9757aef24c7db51a3 /include/uapi/linux/tty_flags.h | |
| parent | 659ae4a027e2f8538303e700d3374860e330a768 (diff) | |
USB: cdc-acm: fix unprivileged TIOCCSERIAL
[ Upstream commit dd5619582d60007139f0447382d2839f4f9e339b ]
TIOCSSERIAL is a horrid, underspecified, legacy interface which for most
serial devices is only useful for setting the close_delay and
closing_wait parameters.
A non-privileged user has only ever been able to set the since long
deprecated ASYNC_SPD flags and trying to change any other *supported*
feature should result in -EPERM being returned. Setting the current
values for any supported features should return success.
Fix the cdc-acm implementation which instead indicated that the
TIOCSSERIAL ioctl was not even implemented when a non-privileged user
set the current values.
Fixes: ba2d8ce9db0a ("cdc-acm: implement TIOCSSERIAL to avoid blocking close(2)")
Acked-by: Oliver Neukum <oneukum@suse.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20210408131602.27956-3-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'include/uapi/linux/tty_flags.h')
0 files changed, 0 insertions, 0 deletions