diff options
| author | David Brownell <david-b@pacbell.net> | 2004-03-29 17:25:17 -0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <greg@kroah.com> | 2004-03-29 17:25:17 -0800 |
| commit | 10766ddeeaf441451237794ad6c0a7ae6dcbf1f1 (patch) | |
| tree | abaf75c192a605030bc8badc4b8572f828822451 /include | |
| parent | 394d72563ef8275323cc7bb85e9d087a3f854b2f (diff) | |
[PATCH] USB: set_configuration locking cleanups
I've posted all these before, the only notable change is
treating that one gphoto2 case as warn-and-continue rather
than return-with-failure.
usb_set_configuration() cleanup
* Remove it from the USB kernel driver API. No drivers need it now,
and the sysadmin can change bConfigurationValue using sysfs (say,
when hotplugging an otherwise problematic device).
* Simpler/cleaner locking: caller must own dev->serialize.
* Access from usbfs now uses usb_reset_configuration() sometimes,
preventing sysfs thrash, and warns about some dangerous usage
(which gphoto2 and other programs may be relying on). (This is
from Alan Stern, but I morphed an error return into a warning.)
* Prevent a couple potential "no configuration" oopses. (Alan's?)
* Remove one broken call from usbcore, in the "device morphed" path
of usb_reset_device(). This should be more polite now, hanging
that one device rather than khubd.
Diffstat (limited to 'include')
| -rw-r--r-- | include/linux/usb.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/include/linux/usb.h b/include/linux/usb.h index e4b60511fc46..f6c4c170750d 100644 --- a/include/linux/usb.h +++ b/include/linux/usb.h @@ -904,7 +904,6 @@ extern int usb_string(struct usb_device *dev, int index, /* wrappers that also update important state inside usbcore */ extern int usb_clear_halt(struct usb_device *dev, int pipe); extern int usb_reset_configuration(struct usb_device *dev); -extern int usb_set_configuration(struct usb_device *dev, int configuration); extern int usb_set_interface(struct usb_device *dev, int ifnum, int alternate); /* |