summaryrefslogtreecommitdiff
path: root/include
diff options
context:
space:
mode:
authorAndrew Morton <akpm@digeo.com>2003-02-11 21:08:37 -0800
committerLinus Torvalds <torvalds@penguin.transmeta.com>2003-02-11 21:08:37 -0800
commit2b8a659cd318133765f3556e169b984f09fd76bb (patch)
treeeef1dbf48f212967e9c665c8fa7ada45097861c8 /include
parentf979631fa01ec4ab6799e57d2e75d5bd0790c454 (diff)
[PATCH] OSS CS4232 locking fixes
Patch from: Peter Waechtler <pwaechtler@mac.com> Addresses BUGME bug #331. "OSS CS4232 nasty spinlock printks on boot" The locking in some OSS modules is really lousy. Because save_flags/cli/restore_flags could be used recursivly - the programmers pushed the locking too far the lower level. Because on ISA cards the register sets are usually multiplexed you had to write to an address latch and then access the data port in an "atomic" manner. I suggest removing the locking from ad_read/ad_write + ad_{enter|leave}_MCE and clamping the locks wherever the functions are called. I hope the attached patch does that correctly. Yes, I don't like all the timeout loops while holding the locks: high chances that a cpu is spinning in interrupt context :(
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions