diff options
| author | Eric W. Biederman <ebiederm@xmission.com> | 2015-01-07 14:28:26 -0600 |
|---|---|---|
| committer | Luis Henriques <luis.henriques@canonical.com> | 2015-05-12 09:36:35 +0100 |
| commit | 4bcf842df09d2cbcd32db82a501383bc6b851fa8 (patch) | |
| tree | c86341af953c5feed5b9fcaa2b46fe42f362b590 /include | |
| parent | f0958ab02d55f76e56f062e685c35ca0ae06018c (diff) | |
mnt: Fail collect_mounts when applied to unmounted mounts
commit cd4a40174b71acd021877341684d8bb1dc8ea4ae upstream.
The only users of collect_mounts are in audit_tree.c
In audit_trim_trees and audit_add_tree_rule the path passed into
collect_mounts is generated from kern_path passed an audit_tree
pathname which is guaranteed to be an absolute path. In those cases
collect_mounts is obviously intended to work on mounted paths and
if a race results in paths that are unmounted when collect_mounts
it is reasonable to fail early.
The paths passed into audit_tag_tree don't have the absolute path
check. But are used to play with fsnotify and otherwise interact with
the audit_trees, so again operating only on mounted paths appears
reasonable.
Avoid having to worry about what happens when we try and audit
unmounted filesystems by restricting collect_mounts to mounts
that appear in the mount tree.
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions
