diff options
| author | Dmitry V. Levin <ldv@altlinux.org> | 2016-02-19 04:27:48 +0300 |
|---|---|---|
| committer | Luis Henriques <luis.henriques@canonical.com> | 2016-03-08 12:15:43 +0000 |
| commit | d34102e6c5701f1d9fda547ad1767788a2b97e1f (patch) | |
| tree | 412fffbf6400a2673e2bdfc8cb6d02f590c20b48 /include | |
| parent | 7fb031c0203f873d2794bcc4faeb59c7783a2564 (diff) | |
unix_diag: fix incorrect sign extension in unix_lookup_by_ino
commit b5f0549231ffb025337be5a625b0ff9f52b016f0 upstream.
The value passed by unix_diag_get_exact to unix_lookup_by_ino has type
__u32, but unix_lookup_by_ino's argument ino has type int, which is not
a problem yet.
However, when ino is compared with sock_i_ino return value of type
unsigned long, ino is sign extended to signed long, and this results
to incorrect comparison on 64-bit architectures for inode numbers
greater than INT_MAX.
This bug was found by strace test suite.
Fixes: 5d3cae8bc39d ("unix_diag: Dumping exact socket core")
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions