summaryrefslogtreecommitdiff
path: root/include
diff options
context:
space:
mode:
authorZou Wei <zou_wei@huawei.com>2021-05-11 15:01:35 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2021-07-20 16:16:11 +0200
commitdc9403097be52d57a5c9c35efa9be79d166a78af (patch)
treee4c9fbd08f33dd14dbdde56298583a4014c39d86 /include
parentfbc5a04b93788fcb0c05e72a24f170f9c23f3403 (diff)
watchdog: Fix possible use-after-free in wdt_startup()
[ Upstream commit c08a6b31e4917034f0ed0cb457c3bb209576f542 ] This module's remove path calls del_timer(). However, that function does not wait until the timer handler finishes. This means that the timer handler may still be running after the driver's remove function has finished, which would result in a use-after-free. Fix by calling del_timer_sync(), which makes sure the timer handler has finished, and unable to re-schedule itself. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zou Wei <zou_wei@huawei.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> Link: https://lore.kernel.org/r/1620716495-108352-1-git-send-email-zou_wei@huawei.com Signed-off-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions