summaryrefslogtreecommitdiff
path: root/kernel
diff options
context:
space:
mode:
authorJohan Hovold <johan@kernel.org>2016-11-01 11:49:56 +0100
committerBen Hutchings <ben@decadent.org.uk>2017-02-23 03:54:27 +0000
commite5eb6913c62999d31c88de843e282a8d97946012 (patch)
tree9bb1465c5e8061a8ec31f810045f54ec3abd10b7 /kernel
parentf0cde54863da281cec1ed85497b4ec58d29c1460 (diff)
PM / sleep: fix device reference leak in test_suspend
commit ceb75787bc75d0a7b88519ab8a68067ac690f55a upstream. Make sure to drop the reference taken by class_find_device() after opening the RTC device. Fixes: 77437fd4e61f (pm: boot time suspend selftest) Signed-off-by: Johan Hovold <johan@kernel.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'kernel')
-rw-r--r--kernel/power/suspend_test.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/kernel/power/suspend_test.c b/kernel/power/suspend_test.c
index 269b097e78ea..743615bfdcec 100644
--- a/kernel/power/suspend_test.c
+++ b/kernel/power/suspend_test.c
@@ -169,8 +169,10 @@ static int __init test_suspend(void)
/* RTCs have initialized by now too ... can we use one? */
dev = class_find_device(rtc_class, NULL, NULL, has_wakealarm);
- if (dev)
+ if (dev) {
rtc = rtc_class_open(dev_name(dev));
+ put_device(dev);
+ }
if (!rtc) {
printk(warn_no_rtc);
goto done;