diff options
| author | Jacob Moroni <jmoroni@google.com> | 2026-02-24 23:41:53 +0000 |
|---|---|---|
| committer | Leon Romanovsky <leonro@nvidia.com> | 2026-02-25 07:50:58 -0500 |
| commit | 104016eb671e19709721c1b0048dd912dc2e96be (patch) | |
| tree | 0a88e8971d6fbb0fc1472bd9d8a73ee4af6786e9 /rust/alloc | |
| parent | 93a4a9b732fbb479f95d327aa867d094aed3f712 (diff) | |
RDMA/umem: Fix double dma_buf_unpin in failure path
In ib_umem_dmabuf_get_pinned_with_dma_device(), the call to
ib_umem_dmabuf_map_pages() can fail. If this occurs, the dmabuf
is immediately unpinned but the umem_dmabuf->pinned flag is still
set. Then, when ib_umem_release() is called, it calls
ib_umem_dmabuf_revoke() which will call dma_buf_unpin() again.
Fix this by removing the immediate unpin upon failure and just let
the ib_umem_release/revoke path handle it. This also ensures the
proper unmap-unpin unwind ordering if the dmabuf_map_pages call
happened to fail due to dma_resv_wait_timeout (and therefore has
a non-NULL umem_dmabuf->sgt).
Fixes: 1e4df4a21c5a ("RDMA/umem: Allow pinned dmabuf umem usage")
Signed-off-by: Jacob Moroni <jmoroni@google.com>
Link: https://patch.msgid.link/20260224234153.1207849-1-jmoroni@google.com
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Diffstat (limited to 'rust/alloc')
0 files changed, 0 insertions, 0 deletions