diff options
| author | Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 2025-02-10 11:18:14 +0100 | 
|---|---|---|
| committer | Jonathan Corbet <corbet@lwn.net> | 2025-02-10 11:19:57 -0700 | 
| commit | 6649b4217089c5d17dc210946baf9c9537c7fb5d (patch) | |
| tree | 2eed1526471a4491f6a8edde27c5c25dabcb6908 /scripts/lib/abi/abi_parser.py | |
| parent | dc525a7650d70668c4d54cf03b4cba793b72cb5a (diff) | |
scripts/lib/abi/abi_parser.py: make it backward-compatible with Python 3.6
Despite being introduced on Python 3.6, the original implementation
was too limited: it doesn't accept anything but the argument.
Even on python 3.10.12, support was still limited, as more complex
operations cause SyntaxError:
	Exception occurred:
	  File ".../linux/Documentation/sphinx/kernel_abi.py", line 48, in <module>
	    from get_abi import AbiParser
	  File ".../linux/scripts/lib/abi/abi_parser.py", line 525
	    msg += f"{part}\n{"-" * len(part)}\n\n"
                       ^
	SyntaxError: f-string: expecting '}'
Replace f-strings by normal string concatenation when it doesn't
work on Python 3.6.
Reported-by: Akira Yokosawa <akiyks@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
Link: https://lore.kernel.org/r/41d2f85df134a46db46fed73a0f9697a3d2ae9ba.1739182025.git.mchehab+huawei@kernel.org
Diffstat (limited to 'scripts/lib/abi/abi_parser.py')
| -rw-r--r-- | scripts/lib/abi/abi_parser.py | 16 | 
1 files changed, 10 insertions, 6 deletions
diff --git a/scripts/lib/abi/abi_parser.py b/scripts/lib/abi/abi_parser.py index 0c3837e52afa..f08de6d3bf7c 100644 --- a/scripts/lib/abi/abi_parser.py +++ b/scripts/lib/abi/abi_parser.py @@ -493,7 +493,7 @@ class AbiParser:                  if cur_part and cur_part != part:                      part = cur_part -                    msg += f"{part}\n{"-" * len(part)}\n\n" +                    msg += part + "\n"+ "-" * len(part) +"\n\n"                  msg += f".. _{key}:\n\n" @@ -517,7 +517,7 @@ class AbiParser:                      msg += f"Defined on file :ref:`{base} <{ref[1]}>`\n\n"              if wtype == "File": -                msg += f"{names[0]}\n{"-" * len(names[0])}\n\n" +                msg += names[0] +"\n" + "-" * len(names[0]) +"\n\n"              desc = v.get("description")              if not desc and wtype != "File": @@ -541,7 +541,8 @@ class AbiParser:              users = v.get("users")              if users and users.strip(" \t\n"): -                msg += f"Users:\n\t{users.strip("\n").replace('\n', '\n\t')}\n\n" +                users = users.strip("\n").replace('\n', '\n\t') +                msg += f"Users:\n\t{users}\n\n"              ln = v.get("line_no", 1) @@ -567,7 +568,9 @@ class AbiParser:                  elif len(lines) == 1:                      f.append(f"{fname}:{lines[0]}")                  else: -                    f.append(f"{fname} lines {", ".join(str(x) for x in lines)}") +                    m = fname + "lines " +                    m += ", ".join(str(x) for x in lines) +                    f.append(m)              self.log.warning("%s is defined %d times: %s", what, len(f), "; ".join(f)) @@ -615,10 +618,11 @@ class AbiParser:                      if users:                          print(f"Users:\t\t\t{users}") -                    print(f"Defined on file{'s'[:len(files) ^ 1]}:\t{", ".join(files)}") +                    print("Defined on file(s):\t" + ", ".join(files))                      if desc: -                        print(f"\n{desc.strip("\n")}\n") +                        desc = desc.strip("\n") +                        print(f"\n{desc}\n")          if not found_keys:              print(f"Regular expression /{expr}/ not found.")  | 
