summaryrefslogtreecommitdiff
path: root/security
diff options
context:
space:
mode:
authorJames Morris <jmorris@redhat.com>2005-01-04 05:39:34 -0800
committerLinus Torvalds <torvalds@ppc970.osdl.org>2005-01-04 05:39:34 -0800
commite5cf15c2bd95d258c23240a451a142e54dc9e067 (patch)
tree49855ffaa7cce4ac7c0d24ce464344f3c8157035 /security
parent6575328c10e7686c6778af59e809bc0fcad60d44 (diff)
[PATCH] SELinux: atomic_dec_and_test() bug
Atomic underflow debugging in this kernel exposed a bug in the AVC RCU code, fix below. The effect of this bug would be delayed node reclamation. Signed-off-by: James Morris <jmorris@redhat.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'security')
-rw-r--r--security/selinux/avc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/security/selinux/avc.c b/security/selinux/avc.c
index c1faf2a958af..936bb34d5bbf 100644
--- a/security/selinux/avc.c
+++ b/security/selinux/avc.c
@@ -281,7 +281,7 @@ static inline int avc_reclaim_node(void)
continue;
list_for_each_entry(node, &avc_cache.slots[hvalue], list) {
- if (!atomic_dec_and_test(&node->ae.used)) {
+ if (atomic_dec_and_test(&node->ae.used)) {
/* Recently Unused */
avc_node_delete(node);
ecx++;