summaryrefslogtreecommitdiff
path: root/docs/develop
diff options
context:
space:
mode:
authorDamien George <damien@micropython.org>2022-12-07 14:42:35 +1100
committerDamien George <damien@micropython.org>2022-12-08 12:27:23 +1100
commit2283b6d68fe77b72e7beeb1bf24778834231b190 (patch)
treee7a03f1b759a2312b5b23a04c475f998b4ca20a7 /docs/develop
parent96c23432f6ef448fdcccdfa6a442d64d7ed06277 (diff)
py: Pass in address to compiled module instead of returning it.
This change makes it so the compiler and persistent code loader take a mp_compiled_module_t* as their last argument, instead of returning this struct. This eliminates a duplicate context variable for all callers of these functions (because the context is now stored in the mp_compiled_module_t by the caller), and also eliminates any confusion about which context to use after the mp_compile_to_raw_code or mp_raw_code_load function returns (because there is now only one context, that stored in mp_compiled_module_t.context). Reduces code size by 16 bytes on ARM Cortex-based ports. Signed-off-by: Damien George <damien@micropython.org>
Diffstat (limited to 'docs/develop')
-rw-r--r--docs/develop/compiler.rst4
1 files changed, 3 insertions, 1 deletions
diff --git a/docs/develop/compiler.rst b/docs/develop/compiler.rst
index 4b43bc08f..cac92585f 100644
--- a/docs/develop/compiler.rst
+++ b/docs/develop/compiler.rst
@@ -152,7 +152,9 @@ The most relevant method you should know about is this:
context->module.globals = mp_globals_get();
// Compile the input parse_tree to a raw-code structure.
- mp_compiled_module_t cm = mp_compile_to_raw_code(parse_tree, source_file, is_repl, context);
+ mp_compiled_module_t cm;
+ cm.context = context;
+ mp_compile_to_raw_code(parse_tree, source_file, is_repl, &cm);
// Create and return a function object that executes the outer module.
return mp_make_function_from_raw_code(cm.rc, cm.context, NULL);