diff options
author | Damien George <damien@micropython.org> | 2024-02-08 16:52:01 +1100 |
---|---|---|
committer | Damien George <damien@micropython.org> | 2024-02-09 11:44:28 +1100 |
commit | b4f59984f7668db457280c1f4007618fd1d235f6 (patch) | |
tree | 1cb5a35670d7752beb49221c687545c0e7393a05 /extmod/btstack/modbluetooth_btstack.c | |
parent | 8cbae12d0d84ebce76b305d2f5535f327d5d44be (diff) |
extmod/btstack: Reset pending_value_handle before calling write-done cb.
The pending_value_handle needs to be freed and reset before calling
mp_bluetooth_gattc_on_read_write_status(), which will call the Python IRQ
handler, which may in turn call back into BTstack to perform an action like
a write. In that case the pending_value_handle will need to be available
for the write/read/etc to proceed.
Fixes issue #13611.
Signed-off-by: Damien George <damien@micropython.org>
Diffstat (limited to 'extmod/btstack/modbluetooth_btstack.c')
-rw-r--r-- | extmod/btstack/modbluetooth_btstack.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/extmod/btstack/modbluetooth_btstack.c b/extmod/btstack/modbluetooth_btstack.c index 211214768..08d64ab01 100644 --- a/extmod/btstack/modbluetooth_btstack.c +++ b/extmod/btstack/modbluetooth_btstack.c @@ -490,11 +490,12 @@ STATIC void btstack_packet_handler_write_with_response(uint8_t packet_type, uint if (!conn) { return; } - mp_bluetooth_gattc_on_read_write_status(MP_BLUETOOTH_IRQ_GATTC_WRITE_DONE, conn_handle, conn->pending_value_handle, status); + uint16_t value_handle = conn->pending_value_handle; conn->pending_value_handle = 0xffff; m_del(uint8_t, conn->pending_write_value, conn->pending_write_value_len); conn->pending_write_value = NULL; conn->pending_write_value_len = 0; + mp_bluetooth_gattc_on_read_write_status(MP_BLUETOOTH_IRQ_GATTC_WRITE_DONE, conn_handle, value_handle, status); } } #endif // MICROPY_PY_BLUETOOTH_ENABLE_GATT_CLIENT |