summaryrefslogtreecommitdiff
path: root/py/modbuiltins.c
diff options
context:
space:
mode:
authorPaul Sokolovsky <pfalcon@users.sourceforge.net>2017-09-18 00:06:43 +0300
committerPaul Sokolovsky <pfalcon@users.sourceforge.net>2017-09-18 00:06:43 +0300
commit9dce823cfd0a9991350184f08a1373f3887134f4 (patch)
tree214ca2cd6d0a6c2a93f3f76dd2f5c76857f3a49f /py/modbuiltins.c
parent72491b3e40db75e7edf5831e8914a1ca5c8e9937 (diff)
py/modbuiltins: Implement abs() by dispatching to MP_UNARY_OP_ABS.
This allows user classes to implement __abs__ special method, and saves code size (104 bytes for x86_64), even though during refactor, an issue was fixed and few optimizations were made: * abs() of minimum (negative) small int value is calculated properly. * objint_longlong and objint_mpz avoid allocating new object is the argument is already non-negative.
Diffstat (limited to 'py/modbuiltins.c')
-rw-r--r--py/modbuiltins.c21
1 files changed, 1 insertions, 20 deletions
diff --git a/py/modbuiltins.c b/py/modbuiltins.c
index 1c76b8073..0486251b6 100644
--- a/py/modbuiltins.c
+++ b/py/modbuiltins.c
@@ -91,26 +91,7 @@ STATIC mp_obj_t mp_builtin___build_class__(size_t n_args, const mp_obj_t *args)
MP_DEFINE_CONST_FUN_OBJ_VAR(mp_builtin___build_class___obj, 2, mp_builtin___build_class__);
STATIC mp_obj_t mp_builtin_abs(mp_obj_t o_in) {
- #if MICROPY_PY_BUILTINS_FLOAT
- if (mp_obj_is_float(o_in)) {
- mp_float_t value = mp_obj_float_get(o_in);
- // TODO check for NaN etc
- if (value < 0) {
- return mp_obj_new_float(-value);
- } else {
- return o_in;
- }
- #if MICROPY_PY_BUILTINS_COMPLEX
- } else if (MP_OBJ_IS_TYPE(o_in, &mp_type_complex)) {
- mp_float_t real, imag;
- mp_obj_complex_get(o_in, &real, &imag);
- return mp_obj_new_float(MICROPY_FLOAT_C_FUN(sqrt)(real*real + imag*imag));
- #endif
- }
- #endif
-
- // this will raise a TypeError if the argument is not integral
- return mp_obj_int_abs(o_in);
+ return mp_unary_op(MP_UNARY_OP_ABS, o_in);
}
MP_DEFINE_CONST_FUN_OBJ_1(mp_builtin_abs_obj, mp_builtin_abs);