summaryrefslogtreecommitdiff
path: root/py
diff options
context:
space:
mode:
authorDave Hylands <dhylands@gmail.com>2014-07-21 16:51:07 -0700
committerDave Hylands <dhylands@gmail.com>2014-07-21 19:10:10 -0700
commit1d8816c36bbb638cd9e5319f820d2b2cf22a9822 (patch)
tree6db71e64e858aa9547e80d4c8829626832b80e3e /py
parent512465bc66082a37cb696ef7c78e3ee878ffd92f (diff)
Deal with reading a buffer less than what was allocated.
With this fix, file_long_read now passes.
Diffstat (limited to 'py')
-rw-r--r--py/stream.c10
1 files changed, 6 insertions, 4 deletions
diff --git a/py/stream.c b/py/stream.c
index 4c8b8a570..5b5fa90df 100644
--- a/py/stream.c
+++ b/py/stream.c
@@ -97,7 +97,7 @@ STATIC mp_obj_t stream_read(uint n_args, const mp_obj_t *args) {
}
int error;
mp_int_t out_sz = o->type->stream_p->read(o, p, more_bytes, &error);
- if (out_sz == -1) {
+ if (out_sz < 0) {
vstr_cut_tail_bytes(&vstr, more_bytes);
if (is_nonblocking_error(error)) {
// With non-blocking streams, we read as much as we can.
@@ -113,11 +113,13 @@ STATIC mp_obj_t stream_read(uint n_args, const mp_obj_t *args) {
nlr_raise(mp_obj_new_exception_msg_varg(&mp_type_OSError, "[Errno %d]", error));
}
- if (out_sz == 0) {
+ if (out_sz < more_bytes) {
// Finish reading.
// TODO what if we have read only half a non-ASCII char?
- vstr_cut_tail_bytes(&vstr, more_bytes);
- break;
+ vstr_cut_tail_bytes(&vstr, more_bytes - out_sz);
+ if (out_sz == 0) {
+ break;
+ }
}
// count chars from bytes just read