summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2017-08-29 15:38:05 -0400
committerTom Lane <tgl@sss.pgh.pa.us>2017-08-29 15:38:40 -0400
commit1e6c3626063571443a828e5fd2e59d9d8b9f0e91 (patch)
treeb2caafed0d8ad9ae149a19aaf8a668b217f855b5
parentd391fb6c3802954661f84ac434c2b557e7437670 (diff)
Doc: document libpq's restriction to INT_MAX rows in a PGresult.
As long as PQntuples, PQgetvalue, etc, use "int" for row numbers, we're pretty much stuck with this limitation. The documentation formerly stated that the result of PQntuples "might overflow on 32-bit operating systems", which is just nonsense: that's not where the overflow would happen, and if you did reach an overflow it would not be on a 32-bit machine, because you'd have OOM'd long since. Discussion: https://postgr.es/m/CA+FnnTxyLWyjY1goewmJNxC==HQCCF4fKkoCTa9qR36oRAHDPw@mail.gmail.com
-rw-r--r--doc/src/sgml/libpq.sgml7
1 files changed, 4 insertions, 3 deletions
diff --git a/doc/src/sgml/libpq.sgml b/doc/src/sgml/libpq.sgml
index bc54c057c7c..2198ea7dd33 100644
--- a/doc/src/sgml/libpq.sgml
+++ b/doc/src/sgml/libpq.sgml
@@ -2878,9 +2878,10 @@ void PQclear(PGresult *res);
<listitem>
<para>
- Returns the number of rows (tuples) in the query result. Because
- it returns an integer result, large result sets might overflow the
- return value on 32-bit operating systems.
+ Returns the number of rows (tuples) in the query result.
+ (Note that <structname>PGresult</> objects are limited to no more
+ than <literal>INT_MAX</> rows, so an <type>int</> result is
+ sufficient.)
<synopsis>
int PQntuples(const PGresult *res);