diff options
| author | Andrew Dunstan <andrew@dunslane.net> | 2012-08-31 20:50:31 -0400 |
|---|---|---|
| committer | Andrew Dunstan <andrew@dunslane.net> | 2012-08-31 20:50:31 -0400 |
| commit | 2d038749017de2d293a524b3f9df7eaae30dbf6a (patch) | |
| tree | 1743308e750ebd22da2e81448f15946ca13927c7 | |
| parent | e46794420ee37f15d3a6da771b7703fcd9b1ea91 (diff) | |
Restore setting of _USE_32BIT_TIME_T to 32 bit MSVC builds.
This was removed in commit cd004067742ee16ee63e55abfb4acbd5f09fbaab,
we're not quite sure why, but there have been reports of crashes due
to AS Perl being built with it when we are not, and it certainly
seems like the right thing to do. There is still some uncertainty
as to why it sometimes fails and sometimes doesn't.
Original patch from Owais Khani, substantially reworked and
extended by Andrew Dunstan.
| -rw-r--r-- | src/tools/msvc/MSBuildProject.pm | 10 | ||||
| -rw-r--r-- | src/tools/msvc/VCBuildProject.pm | 11 |
2 files changed, 17 insertions, 4 deletions
diff --git a/src/tools/msvc/MSBuildProject.pm b/src/tools/msvc/MSBuildProject.pm index ac99345fa6d..2e3eab6599d 100644 --- a/src/tools/msvc/MSBuildProject.pm +++ b/src/tools/msvc/MSBuildProject.pm @@ -61,16 +61,22 @@ EOF print $f <<EOF; </PropertyGroup> EOF + + # We have to use this flag on 32 bit targets because the 32bit perls + # are built with it and sometimes crash if we don't. + my $use_32bit_time_t = + $self->{platform} eq 'Win32' ? '_USE_32BIT_TIME_T;' : ''; + $self->WriteItemDefinitionGroup( $f, 'Debug', - { defs => '_DEBUG;DEBUG=1;', + { defs => "_DEBUG;DEBUG=1;$use_32bit_time_t", opt => 'Disabled', strpool => 'false', runtime => 'MultiThreadedDebugDLL' }); $self->WriteItemDefinitionGroup( $f, 'Release', - { defs => '', + { defs => "$use_32bit_time_t", opt => 'Full', strpool => 'true', runtime => 'MultiThreadedDLL' }); diff --git a/src/tools/msvc/VCBuildProject.pm b/src/tools/msvc/VCBuildProject.pm index 1022329dce2..624682601b3 100644 --- a/src/tools/msvc/VCBuildProject.pm +++ b/src/tools/msvc/VCBuildProject.pm @@ -32,9 +32,16 @@ sub WriteHeader <Platforms><Platform Name="$self->{platform}"/></Platforms> <Configurations> EOF + + # We have to use this flag on 32 bit targets because the 32bit perls + # are built with it and sometimes crash if we don't. + my $use_32bit_time_t = + $self->{platform} eq 'Win32' ? '_USE_32BIT_TIME_T;' : ''; + + $self->WriteConfiguration( $f, 'Debug', - { defs => '_DEBUG;DEBUG=1;', + { defs => "_DEBUG;DEBUG=1;$use_32bit_time_t", wholeopt => 0, opt => 0, strpool => 'false', @@ -42,7 +49,7 @@ EOF $self->WriteConfiguration( $f, 'Release', - { defs => '', + { defs => "$use_32bit_time_t", wholeopt => 0, opt => 3, strpool => 'true', |