diff options
| author | Noah Misch <noah@leadboat.com> | 2018-04-25 18:50:29 -0700 |
|---|---|---|
| committer | Noah Misch <noah@leadboat.com> | 2018-04-25 18:50:33 -0700 |
| commit | 32c247629367c827b09e65d135d0a26fc91eb8fa (patch) | |
| tree | c99ae931e0d1b8a1d3e28a325c533c881c1fccd4 | |
| parent | c76d0eed270ee6d160d6e37feb814bf8b53189a2 (diff) | |
Correct pg_recvlogical server version test.
The predecessor test boiled down to "PQserverVersion(NULL) >= 100000",
which is always false. No release includes that, so it could not have
reintroduced CVE-2018-1058. Back-patch to 9.4, like the addition of the
predecessor in commit 8d2814f274def85f39fbe997d454b01628cb5667.
Discussion: https://postgr.es/m/20180422215551.GB2676194@rfd.leadboat.com
| -rw-r--r-- | src/bin/pg_basebackup/streamutil.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/bin/pg_basebackup/streamutil.c b/src/bin/pg_basebackup/streamutil.c index 97484aa573d..933091ff1f8 100644 --- a/src/bin/pg_basebackup/streamutil.c +++ b/src/bin/pg_basebackup/streamutil.c @@ -215,7 +215,7 @@ GetConnection(void) * 10, so the search path cannot be changed (by us or attackers) on * earlier versions. */ - if (dbname != NULL && PQserverVersion(conn) >= 100000) + if (dbname != NULL && PQserverVersion(tmpconn) >= 100000) { PGresult *res; |