diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2022-10-16 15:27:04 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2022-10-16 15:27:04 -0400 |
| commit | 3d7df87c4bba27f1d1dcc5d92e7997b82cedd458 (patch) | |
| tree | 236cecaba8c9a72bbbe6a506f6a4701c8e1e3ba4 | |
| parent | d33ac1ec2af5297b2ac8fbf89464f0c7f90a7955 (diff) | |
Rename parser token REF to REF_P to avoid a symbol conflict.
In the latest version of Apple's macOS SDK, <sys/socket.h>
fails to compile if "REF" is #define'd as something.
Apple may or may not agree that this is a bug, and even if
they do accept the bug report I filed, they probably won't
fix it very quickly. In the meantime, our back branches will all
fail to compile gram.y. v15 and HEAD currently escape the problem
thanks to the refactoring done in 98e93a1fc, but that's purely
accidental. Moreover, since that patch removed a widely-visible
inclusion of <netdb.h>, back-patching it seems too likely to break
third-party code.
Instead, change the token's code name to REF_P, following our usual
convention for naming parser tokens that are likely to have symbol
conflicts. The effects of that should be localized to the grammar
and immediately surrounding files, so it seems like a safer answer.
Per project policy that we want to keep recently-out-of-support
branches buildable on modern systems, back-patch all the way to 9.2.
Discussion: https://postgr.es/m/1803927.1665938411@sss.pgh.pa.us
| -rw-r--r-- | src/backend/parser/gram.y | 6 | ||||
| -rw-r--r-- | src/include/parser/kwlist.h | 2 |
2 files changed, 4 insertions, 4 deletions
diff --git a/src/backend/parser/gram.y b/src/backend/parser/gram.y index e820606338c..651fd893e7c 100644 --- a/src/backend/parser/gram.y +++ b/src/backend/parser/gram.y @@ -673,7 +673,7 @@ static Node *makeRecursiveViewSelect(char *relname, List *aliases, Node *query); QUOTE - RANGE READ REAL REASSIGN RECHECK RECURSIVE REF REFERENCES REFERENCING + RANGE READ REAL REASSIGN RECHECK RECURSIVE REF_P REFERENCES REFERENCING REFRESH REINDEX RELATIVE_P RELEASE RENAME REPEATABLE REPLACE REPLICA RESET RESTART RESTRICT RETURNING RETURNS REVOKE RIGHT ROLE ROLLBACK ROLLUP ROUTINE ROUTINES ROW ROWS RULE @@ -14008,7 +14008,7 @@ xmlexists_argument: ; xml_passing_mech: - BY REF + BY REF_P | BY VALUE_P ; @@ -15213,7 +15213,7 @@ unreserved_keyword: | REASSIGN | RECHECK | RECURSIVE - | REF + | REF_P | REFERENCING | REFRESH | REINDEX diff --git a/src/include/parser/kwlist.h b/src/include/parser/kwlist.h index 00ace8425e2..a3f3890e8ce 100644 --- a/src/include/parser/kwlist.h +++ b/src/include/parser/kwlist.h @@ -323,7 +323,7 @@ PG_KEYWORD("real", REAL, COL_NAME_KEYWORD) PG_KEYWORD("reassign", REASSIGN, UNRESERVED_KEYWORD) PG_KEYWORD("recheck", RECHECK, UNRESERVED_KEYWORD) PG_KEYWORD("recursive", RECURSIVE, UNRESERVED_KEYWORD) -PG_KEYWORD("ref", REF, UNRESERVED_KEYWORD) +PG_KEYWORD("ref", REF_P, UNRESERVED_KEYWORD) PG_KEYWORD("references", REFERENCES, RESERVED_KEYWORD) PG_KEYWORD("referencing", REFERENCING, UNRESERVED_KEYWORD) PG_KEYWORD("refresh", REFRESH, UNRESERVED_KEYWORD) |