diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2015-12-01 11:42:25 -0500 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2015-12-01 11:42:43 -0500 |
| commit | 3e6e98c5a8551e3b90bbc82d5bdad2f574a6f508 (patch) | |
| tree | d9d9f81c9850eb4405b3722e012dd2cab1582192 | |
| parent | 6823bc282943b44a57cdde3921621f7d83598d83 (diff) | |
Use "g" not "f" format in ecpg's PGTYPESnumeric_from_double().
The previous coding could overrun the provided buffer size for a very large
input, or lose precision for a very small input. Adopt the methodology
that's been in use in the equivalent backend code for a long time.
Per private report from Bas van Schaik. Back-patch to all supported
branches.
| -rw-r--r-- | src/interfaces/ecpg/pgtypeslib/numeric.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/interfaces/ecpg/pgtypeslib/numeric.c b/src/interfaces/ecpg/pgtypeslib/numeric.c index 84d73b7bb7b..35eacf86503 100644 --- a/src/interfaces/ecpg/pgtypeslib/numeric.c +++ b/src/interfaces/ecpg/pgtypeslib/numeric.c @@ -2,6 +2,7 @@ #include "postgres_fe.h" #include <ctype.h> +#include <float.h> #include <limits.h> #include "extern.h" @@ -1497,11 +1498,11 @@ PGTYPESnumeric_copy(numeric *src, numeric *dst) int PGTYPESnumeric_from_double(double d, numeric *dst) { - char buffer[100]; + char buffer[DBL_DIG + 100]; numeric *tmp; int i; - if (sprintf(buffer, "%f", d) == 0) + if (sprintf(buffer, "%.*g", DBL_DIG, d) <= 0) return -1; if ((tmp = PGTYPESnumeric_from_asc(buffer, NULL)) == NULL) |