diff options
| author | Tomas Vondra <tomas.vondra@postgresql.org> | 2024-12-17 15:40:07 +0100 |
|---|---|---|
| committer | Tomas Vondra <tomas.vondra@postgresql.org> | 2024-12-17 15:48:29 +0100 |
| commit | 42eae257cfcaa1d20e4f555d14934388ac434c61 (patch) | |
| tree | 79ceacf7b67049535f26e5b02e60dc09ab7eda34 | |
| parent | 88baa2791418c6a1e57064fd48392bb0ebce694b (diff) | |
Update comments about index parallel builds
Commit b43757171470 allowed parallel builds for BRIN, but left behind
two comments claiming only btree indexes support parallel builds.
Reported by Egor Rogov, along with similar issues in SGML docs.
Backpatch to 17, where parallel builds for BRIN were introduced.
Reported-by: Egor Rogov
Backpatch-through: 17
Discussion: https://postgr.es/m/114e2d5d-125e-07d8-94aa-5ad175fb7443@postgrespro.ru
| -rw-r--r-- | src/backend/catalog/index.c | 2 | ||||
| -rw-r--r-- | src/backend/optimizer/plan/planner.c | 3 |
2 files changed, 3 insertions, 2 deletions
diff --git a/src/backend/catalog/index.c b/src/backend/catalog/index.c index 6c47b3cd739..abd8eef0865 100644 --- a/src/backend/catalog/index.c +++ b/src/backend/catalog/index.c @@ -2958,7 +2958,7 @@ index_build(Relation heapRelation, /* * Determine worker process details for parallel CREATE INDEX. Currently, - * only btree has support for parallel builds. + * only btree and BRIN have support for parallel builds. * * Note that planner considers parallel safety for us. */ diff --git a/src/backend/optimizer/plan/planner.c b/src/backend/optimizer/plan/planner.c index f2c05f31f68..39ade99155f 100644 --- a/src/backend/optimizer/plan/planner.c +++ b/src/backend/optimizer/plan/planner.c @@ -6768,7 +6768,8 @@ plan_cluster_use_sort(Oid tableOid, Oid indexOid) * CREATE INDEX should request for use * * tableOid is the table on which the index is to be built. indexOid is the - * OID of an index to be created or reindexed (which must be a btree index). + * OID of an index to be created or reindexed (which must be an index with + * support for parallel builds - currently btree or BRIN). * * Return value is the number of parallel worker processes to request. It * may be unsafe to proceed if this is 0. Note that this does not include the |