diff options
| author | Alvaro Herrera <alvherre@alvh.no-ip.org> | 2019-07-26 17:46:40 -0400 |
|---|---|---|
| committer | Alvaro Herrera <alvherre@alvh.no-ip.org> | 2019-07-26 17:46:40 -0400 |
| commit | 52608f3416075dc57a8e12ff0c3e6af03549c7d5 (patch) | |
| tree | e87cacf2aeecd395bf5ddc784c6e7a212e0a318b | |
| parent | 46c193213adb4cbcdd0f8198b361de27d0ca13fe (diff) | |
Don't uselessly escape a string that doesn't need escaping
Per gripe from Ian Barwick
Co-authored-by: Ian Barwick <ian@2ndquadrant.com>
Discussion: https://postgr.es/m/CABvVfJWNnNKb8cHsTLhkTsvL1+G6BVcV+57+w1JZ61p8YGPdWQ@mail.gmail.com
| -rw-r--r-- | src/bin/pg_basebackup/pg_basebackup.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/bin/pg_basebackup/pg_basebackup.c b/src/bin/pg_basebackup/pg_basebackup.c index 33c1d4efe36..19ebf6d1a57 100644 --- a/src/bin/pg_basebackup/pg_basebackup.c +++ b/src/bin/pg_basebackup/pg_basebackup.c @@ -1650,9 +1650,9 @@ GenerateRecoveryConf(PGconn *conn) if (replication_slot) { - escaped = escape_quotes(replication_slot); - appendPQExpBuffer(recoveryconfcontents, "primary_slot_name = '%s'\n", replication_slot); - free(escaped); + /* unescaped: ReplicationSlotValidateName allows [a-z0-9_] only */ + appendPQExpBuffer(recoveryconfcontents, "primary_slot_name = '%s'\n", + replication_slot); } if (PQExpBufferBroken(recoveryconfcontents) || |