summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRobert Haas <rhaas@postgresql.org>2011-01-26 06:42:51 -0500
committerRobert Haas <rhaas@postgresql.org>2011-01-26 06:42:51 -0500
commit5c2a7c6e97741564ab4ff336eac8d8227485dd4c (patch)
treeb678ff014c1034f2fd2098653f9432c20d3130c4
parenta06e41deebdf74b8b5109329dc75b2e9d9057962 (diff)
Add a comment explaining why we force physical removal of OIDs.
Noah Misch, slightly revised.
-rw-r--r--src/backend/commands/tablecmds.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
index 8a281968ad8..8fa9d7fa7f1 100644
--- a/src/backend/commands/tablecmds.c
+++ b/src/backend/commands/tablecmds.c
@@ -4942,7 +4942,9 @@ ATExecDropColumn(List **wqueue, Relation rel, const char *colName,
/*
* If we dropped the OID column, must adjust pg_class.relhasoids and tell
- * Phase 3 to physically get rid of the column.
+ * Phase 3 to physically get rid of the column. We formerly left the
+ * column in place physically, but this caused subtle problems. See
+ * http://archives.postgresql.org/pgsql-hackers/2009-02/msg00363.php
*/
if (attnum == ObjectIdAttributeNumber)
{