diff options
| author | Robert Haas <rhaas@postgresql.org> | 2015-08-04 12:58:54 -0400 |
|---|---|---|
| committer | Robert Haas <rhaas@postgresql.org> | 2015-08-04 13:05:58 -0400 |
| commit | 5ef8e1114774ea65eb03f48846e1d708ca8da4be (patch) | |
| tree | 2e3c5513361cc9660b63cfa11a8ceb9c3132c134 | |
| parent | 121869fe41a73ae4381b4d1342b0f9f114866326 (diff) | |
Cap wal_buffers to avoid a server crash when it's set very large.
It must be possible to multiply wal_buffers by XLOG_BLCKSZ without
overflowing int, or calculations in StartupXLOG will go badly wrong
and crash the server. Avoid that by imposing a maximum value on
wal_buffers. This will be just under 2GB, assuming the usual value
for XLOG_BLCKSZ.
Josh Berkus, per an analysis by Andrew Gierth.
| -rw-r--r-- | src/backend/utils/misc/guc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c index d613846310b..3ee64d43d83 100644 --- a/src/backend/utils/misc/guc.c +++ b/src/backend/utils/misc/guc.c @@ -1991,7 +1991,7 @@ static struct config_int ConfigureNamesInt[] = GUC_UNIT_XBLOCKS }, &XLOGbuffers, - -1, -1, INT_MAX, + -1, -1, (INT_MAX / XLOG_BLCKSZ), check_wal_buffers, NULL, NULL }, |