summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2014-01-30 18:10:06 -0500
committerTom Lane <tgl@sss.pgh.pa.us>2014-01-30 18:10:06 -0500
commit62acbdaae45505bfa49fa80c730d0b289cfb6c0b (patch)
tree4425d80d3e5dbe66436a7878b7bc06635a140fde
parent3e71ce1e9ab73a829ae3ddbcd9b03e6673e39c3e (diff)
Fix potential coredump on bad locale value in pg_upgrade.
Thinko in error report (and a typo in the message text, too). We're failing anyway, but it would be good to print something useful first. Noted while reviewing a patch to make pg_upgrade's locale code laxer.
-rw-r--r--contrib/pg_upgrade/check.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/contrib/pg_upgrade/check.c b/contrib/pg_upgrade/check.c
index e9e9a4fe339..32b9bb998ae 100644
--- a/contrib/pg_upgrade/check.c
+++ b/contrib/pg_upgrade/check.c
@@ -979,7 +979,7 @@ get_canonical_locale_name(int category, const char *locale)
res = setlocale(category, locale);
if (!res)
- pg_log(PG_FATAL, "failed to get system local name for \"%s\"\n", res);
+ pg_log(PG_FATAL, "failed to get system locale name for \"%s\"\n", locale);
res = pg_strdup(res);