summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2011-04-02 18:05:46 -0400
committerTom Lane <tgl@sss.pgh.pa.us>2011-04-02 18:05:46 -0400
commit672def62259354f28000e8cfb97b6668192369c2 (patch)
tree8809d8dfd89aa44eb63e959b9f1465d9a614cf96
parent7b99cfbe565e1b2193cefff79f2476c8373b7c61 (diff)
Fix typo in PQconnectStartParams().
This would lead to leaking the PGconn structure after an error detected by conninfo_array_parse(), as well as failing to return a useful error message in such cases. Backpatch to 9.0 where the error was introduced. Joseph Adams
-rw-r--r--src/interfaces/libpq/fe-connect.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/interfaces/libpq/fe-connect.c b/src/interfaces/libpq/fe-connect.c
index 4c59ca6834f..6eb64925356 100644
--- a/src/interfaces/libpq/fe-connect.c
+++ b/src/interfaces/libpq/fe-connect.c
@@ -446,7 +446,7 @@ PQconnectStartParams(const char **keywords,
{
conn->status = CONNECTION_BAD;
/* errorMessage is already set */
- return false;
+ return conn;
}
/*