diff options
| author | Tomas Vondra <tomas.vondra@postgresql.org> | 2019-01-19 20:36:07 +0100 |
|---|---|---|
| committer | Tomas Vondra <tomas.vondra@postgresql.org> | 2019-01-19 20:36:07 +0100 |
| commit | 6f090c1d8d226d214edd8958d0df561513b0547f (patch) | |
| tree | 13385dc8bcf92f31a7bad87ba1bc9f3cddc69acd | |
| parent | b161ffe3175996d08d88d7e7d990959212dc81a1 (diff) | |
Revert "Add valgrind suppressions for wcsrtombs optimizations"
This reverts commit 41344896364c4bf2229ec590c95cf23a6bec928e.
Per discussion, it's not desirable to add valgrind suppressions for
outside our own code base (e.g. glibc in this case), especially when
the suppressions may be platform-specific. There are better ways to
deal with that, e.g. by providing local suppressions.
Discussion: https://www.postgresql.org/message-id/flat/90ac0452-e907-e7a4-b3c8-15bd33780e62%402ndquadrant.com
| -rw-r--r-- | src/tools/valgrind.supp | 36 |
1 files changed, 0 insertions, 36 deletions
diff --git a/src/tools/valgrind.supp b/src/tools/valgrind.supp index 7151d24ad31..5f15ac13afd 100644 --- a/src/tools/valgrind.supp +++ b/src/tools/valgrind.supp @@ -212,39 +212,3 @@ Memcheck:Cond fun:PyObject_Realloc } - -# wcsrtombs uses some clever optimizations internally, which to valgrind -# may look like access to uninitialized data. For example AVX2 instructions -# load data in 256-bit chunks, irrespectedly of wchar length. gconv does -# somethink similar by loading data in 32bit chunks and then shifting the -# data internally. Neither of those actually uses the uninitialized part -# of the buffer, as far as we know. -# -# https://www.postgresql.org/message-id/90ac0452-e907-e7a4-b3c8-15bd33780e62@2ndquadrant.com - -{ - wcsnlen_optimized - Memcheck:Cond - ... - fun:wcsrtombs - fun:wcstombs - fun:wchar2char -} - -{ - wcsnlen_optimized_addr32 - Memcheck:Addr32 - ... - fun:wcsrtombs - fun:wcstombs - fun:wchar2char -} - -{ - gconv_transform_internal - Memcheck:Cond - fun:__gconv_transform_internal_utf8 - fun:wcsrtombs - fun:wcstombs - fun:wchar2char -} |