summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNoah Misch <noah@leadboat.com>2025-08-10 13:05:13 -0700
committerNoah Misch <noah@leadboat.com>2025-08-10 13:05:17 -0700
commit70637d7ae0a20caffe88559a689a2a00cb1a1d2b (patch)
tree7bf2884d88562f9ac150fc87de6ff6f2ebc3dace
parentf0d55b68ef920b5ed22c3788a5dfc15fe1f70be7 (diff)
Remove, from stable branches, the new assertion of no pg_dump OID sort.
Commit 0decd5e89db9f5edb9b27351082f0d74aae7a9b6 recently added the assertion to confirm dump order remains independent of OID values. The assertion remained reachable via DO_DEFAULT_ACL. Given the release wrap tomorrow, make the assertion master-only. Reported-by: Alexander Lakhin <exclusion@gmail.com> Reviewed-by: Robert Haas <robertmhaas@gmail.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/d32aaa8d-df7c-4f94-bcb3-4c85f02bea21@gmail.com Backpatch-through: 13-18
-rw-r--r--src/bin/pg_dump/pg_dump_sort.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/src/bin/pg_dump/pg_dump_sort.c b/src/bin/pg_dump/pg_dump_sort.c
index 38ad6aad118..09799c98f66 100644
--- a/src/bin/pg_dump/pg_dump_sort.c
+++ b/src/bin/pg_dump/pg_dump_sort.c
@@ -447,7 +447,6 @@ DOTypeNameCompare(const void *p1, const void *p2)
* consequence of the test using "pg_restore -j", which doesn't fully
* constrain OID assignment order.
*/
- Assert(false);
return oidcmp(obj1->catId.oid, obj2->catId.oid);
}