diff options
| author | Heikki Linnakangas <heikki.linnakangas@iki.fi> | 2010-10-20 22:20:33 +0300 |
|---|---|---|
| committer | Heikki Linnakangas <heikki.linnakangas@iki.fi> | 2010-10-20 22:25:22 +0300 |
| commit | 77f8685bec94b642f1606f64cca6080a2d834441 (patch) | |
| tree | d1390bacaa93c180bece1e61f613a162c1968eb5 | |
| parent | 2f4b1498bcd025ce96f460416ccb68b2b992c485 (diff) | |
If pk is NULL, the backend would segfault when accessing ->algo and the
following NULL check was never reached.
This problem was found by Coccinelle (null_ref.cocci from coccicheck).
Marti Raudsepp
| -rw-r--r-- | contrib/pgcrypto/pgp-pubenc.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/contrib/pgcrypto/pgp-pubenc.c b/contrib/pgcrypto/pgp-pubenc.c index de729476f59..7db6ce1ee9d 100644 --- a/contrib/pgcrypto/pgp-pubenc.c +++ b/contrib/pgcrypto/pgp-pubenc.c @@ -199,7 +199,7 @@ pgp_write_pubenc_sesskey(PGP_Context * ctx, PushFilter * dst) PGP_PubKey *pk = ctx->pub_key; uint8 ver = 3; PushFilter *pkt = NULL; - uint8 algo = pk->algo; + uint8 algo; if (pk == NULL) { @@ -207,6 +207,8 @@ pgp_write_pubenc_sesskey(PGP_Context * ctx, PushFilter * dst) return PXE_BUG; } + algo = pk->algo; + /* * now write packet */ |